Skip to content

Conversation

@hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Feb 16, 2024

Update version of diasymreader to 17.8.7-beta1.24113.1

Customer Impact

This comes from a request of the Roslyn team as newer reader is needed to emit toolset information into debug streams. This aligns the toolset with best practices for supply chain and is needed for LTS use of the toolchain.

Regression

  • Yes
  • No

Testing

  • The scenarios called out in the risks section have limited test in automation. Some scenarios are currently being manually tested.

Risk

Moderate. The following areas use this library:

  • NativeAOT classic PDB generation. R2R ni PDB generation.
  • Roslyn generation of portable PDBs.
  • Uncommon JIT path where explicit sequence points are requested explicitly from the PDB.
  • Exception.ToString.

@ghost ghost assigned hoyosjs Feb 16, 2024
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 16, 2024
@hoyosjs hoyosjs requested a review from a team February 16, 2024 03:34
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 8.0.x

@jeffschwMSFT jeffschwMSFT added Servicing-consider Issue for next servicing release review area-Diagnostics-coreclr labels Feb 16, 2024
@jeffschwMSFT jeffschwMSFT added this to the 8.0.x milestone Feb 16, 2024
@ghost
Copy link

ghost commented Feb 16, 2024

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Update version of diasymreader to 17.8.7-beta1.24113.1

Customer Impact

This comes from a request of the Roslyn team as newer reader is needed to emit toolset information into debug streams. This aligns the toolset with best practices for supply chain and is needed for LTS use of the toolchain.

Regression

  • Yes
  • No

Testing

  • The scenarios called out in the risks section have limited test in automation. Some scenarios are currently being manually tested.

Risk

Moderate. The following areas use this library:

  • NativeAOT classic PDB generation. R2R ni PDB generation.
  • Roslyn generation of portable PDBs.
  • Uncommon JIT path where explicit sequence points are requested explicitly from the PDB.
  • Exception.ToString.
Author: hoyosjs
Assignees: hoyosjs
Labels:

Servicing-consider, area-Diagnostics-coreclr, needs-area-label

Milestone: -

@danmoseley danmoseley removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 20, 2024
@rbhanda rbhanda modified the milestones: 8.0.x, 8.0.3 Feb 20, 2024
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Feb 20, 2024
@carlossanlop
Copy link
Contributor

Wrong milestone (applied on Feb 20th). Code Complete for 8.0.3 was on Feb 12th. This will have to go to 8.0.4 if merged before the next Code Complete (March 11th).

@carlossanlop carlossanlop modified the milestones: 8.0.3, 8.0.4 Feb 27, 2024
@hoyosjs hoyosjs merged commit a3de6b7 into release/8.0-staging Feb 27, 2024
@hoyosjs hoyosjs deleted the juhoyosa/dia-to-17.8.7 branch February 27, 2024 20:45
@hoyosjs
Copy link
Member Author

hoyosjs commented Feb 27, 2024

Failure reproduced in other staging PR's. Run too old to rerun:

let failedTests = (methodName : string, includePR : bool, messageSubstr: string, includePassedOnRerun : bool) {
cluster('engsrvprod.kusto.windows.net').database('engineeringdata').AzureDevOpsTests
    | where TestName startswith "System.Net" 
    | where includePassedOnRerun or (Outcome == 'Failed')
    | extend startOfTestName = indexof_regex(TestName, @"[^.]+$")
    | extend Method = substring(TestName, startOfTestName)
    | extend Type = substring(TestName, 0, startOfTestName - 1)
    | project-away startOfTestName
    | where Method == methodName
    | where Message contains messageSubstr
    | distinct JobId, WorkItemId, Message, StackTrace, Method, Type, Arguments, Outcome
    | join kind=inner (cluster('engsrvprod.kusto.windows.net').database('engineeringdata').Jobs
        | where ((Branch == 'refs/heads/main') or (Branch == 'refs/heads/master') or (includePR and (Source startswith "pr/")))
        | where Type startswith "test/functional/cli/"
            and not(Properties contains "runtime-staging")
        | summarize arg_max(Finished, Properties, Type, Branch, Source, Started, QueueName) by JobId
        | project-rename JobType = Type) on JobId
    | extend PropertiesJson = parse_json(Properties)
    | extend OS = replace_regex(tostring(PropertiesJson.operatingSystem), @'\((.*)\).*|([^\(].*)', @'\1\2')
    | extend Runtime = iif(PropertiesJson.runtimeFlavor == "mono", "Mono", iif(PropertiesJson.DefinitionName contains "coreclr", "CoreCLR", ""))
    | extend TargetBranch = extractjson("$.['System.PullRequest.TargetBranch']", Properties)
    | extend Architecture = PropertiesJson.architecture
    | extend Scenario = iif(isempty(PropertiesJson.scenario), "--", PropertiesJson.scenario)
    //| extend DefinitionName = PropertiesJson.DefinitionName
    | project-away PropertiesJson
};
failedTests('ConnectWithRevocation_WithCallback', true, 'An unknown chain building error occurred', true);

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants