[wasm] Disable jiterpreter_do_jit_call to address issues with disabling Wasm EH on 8.0. #98051
Conversation
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThis functionality is already gone in 9.0, and isn't terribly important. We just didn't get around to removing it before 8.0 released. The exported C function is kept (as a no-op) so that any TS/JS code touching it won't break. I believe this will fix #95963 but haven't been able to verify that locally yet.
|
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos Issue DetailsThis functionality is already gone in 9.0, and isn't terribly important. We just didn't get around to removing it before 8.0 released. The exported C function is kept (as a no-op) so that any TS/JS code touching it won't break. I believe this will fix #95963 but haven't been able to verify that locally yet.
|
c41a281 to
0576c67
Compare
Customer Impact
This code causes a startup failure in AOT'd wasm applications if they are rebuilt with exception handling turned off.
The functionality being removed is already gone in 9.0, and isn't terribly important. We just didn't get around to removing it before 8.0 released. It's not clear to me what's wrong with it, but I can verify locally that doing AOT builds with EH switched off causes it to misbehave, and removing it makes my local repros not break anymore.
The exported C function is kept (as a no-op) so that any TS/JS code touching it won't break.
I believe this will fix #95963 but haven't been able to verify that locally yet.
Regression
I don't have any reason to believe this code regressed after it was initially added, though I recall testing it and having it work. We don't (AFAIK) have much CI coverage for this scenario, and we rarely test it manually.
Testing
Manual verification. I may look into adding a WBT test for it later, but I can't build/run WBTs right now due to an unrelated problem.
Risk
Low risk. We did this on main (9.0) a while ago, and the code being removed is an optimization, so we're falling back to well-tested old code.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.