[release/8.0-staging] Remove use of NewHolder<> as field.
#97843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 2, 2024
jkotas
approved these changes
Feb 2, 2024
jeffschwMSFT
approved these changes
Feb 2, 2024
Member
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we will take for consideration in 8.0.x
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #97837 to release/8.0-staging
/cc @AaronRobinsonMSFT
Customer Impact
The issue was found in some Watson buckets and reported from customer WinRT applications. The result is a random crash in heavily concurrent COM applications.
Regression
Testing
All relevant tests pass. This is removing an abstraction so no functional change.
Risk
Low. This is removing an abstraction with no practical change. The abstraction was calling
deleteimplicitly. Removing the abstraction now requires an explicit call todelete.IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.