Skip to content

Conversation

@jkoritzinsky
Copy link
Member

Treat ref readonly the same as we treat in.

Fixes #97706

@jkoritzinsky jkoritzinsky added area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature labels Jan 30, 2024
@ghost
Copy link

ghost commented Jan 30, 2024

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Treat ref readonly the same as we treat in.

Fixes #97706

Author: jkoritzinsky
Assignees: -
Labels:

area-System.Runtime.InteropServices, source-generator

Milestone: -

@ghost ghost assigned jkoritzinsky Jan 30, 2024
@jkoritzinsky jkoritzinsky requested a review from a team January 30, 2024 20:37
@jkoritzinsky
Copy link
Member Author

Adding runtime-infra for review for the Roslyn upgrade.

@jkoritzinsky
Copy link
Member Author

Looks like the Roslyn upgrade is being done in #97767.

When that's merged, I'll revert the Roslyn reference changes here.

Treat `ref readonly` the same as we treat `in`.

Fixes dotnet#97706
@jkoritzinsky
Copy link
Member Author

Failures are known or an infra issue

@jkoritzinsky jkoritzinsky merged commit 58601ba into dotnet:main Feb 2, 2024
@jkoritzinsky jkoritzinsky deleted the ref-readonly branch February 2, 2024 00:48
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[LibraryImport] throws NotImplementedException on ref readonly parameters

3 participants