Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

@martincostello The original issue reported in #97498 was about The type or namespace name 'DynamicallyAccessedMembersAttribute' could not be found (are you missing a using directive or an assembly reference?). But you are saying Strip generic type parameter attributes from partial classes emitted by the logging source generator to avoid CS0579 errors from duplicate attributes. .

I expect to fix this by fully qualifying the attribute in the emitted source. What exactly causes CS0579 errors from duplicate attributes?

CC @eerhardt if you have any input for this.

What exactly causes CS0579 errors from duplicate attributes?

Having the attributes defined in both partial classes, it just flat-out doesn't compile. Adding the usings/fully-qualifying just causes a new CS0579 error.

#97498 (comment)

As far as I can tell, only one partial class can annotate the type parameters, so the generator shouldn't emit them and leave it up to the user's code to do so. That's what this PR does.

CC @geeknoid and @joperezr as FYI.

@martincostello I see what you are saying now. Thanks for clarification.

@tarekgh No problem!

Is this change something that could be considered for backporting to 8.0 after merge?

We have a base library targeting net8.0 we use internally for building serverless apps that makes heavy use of generics and the logging source generator. I found this issue while working on adding AoT support to it.

This issue blocks us from adopting native AoT there without significant refactoring of all the logging in that library, which in turn blocks all the apps built on top of it.

Is this change something that could be considered for backporting to 8.0 after merge?

I can check if this is meeting the servicing bar. Let's get this first in the main and then we can follow-up to see if we can port it to servicing.

CC @ericstj

/backport to release/8.0-staging

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7716311245

@martincostello this is now ported to servicing branch. Will be released around March.

@tarekgh Thanks! ❤️