[release/8.0-staging] Gen0 segment should always be reported as Gen0 for DacHeapWalker #96861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @tommcdon Issue DetailsBackport of #96640 to release/8.0-staging Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
jeffschwMSFT
approved these changes
Jan 11, 2024
Member
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we will take for consideration in 8.0.x
tommcdon
approved these changes
Jan 12, 2024
Contributor
|
@cshung have you sent an email to Tactics requesting approval? Friendly reminder that Tuesday January 16th 4pm is the Code Complete deadline for the February Release. If all requirements are met, please merge your PR before that date and time to ensure this fix gets included in that Release. |
Contributor
I think @hoyosjs did, but I will let him confirm. |
Member
|
it was approved in mail. can we look at the ci failures? when can we remove the no_merge label? |
Contributor
|
Edit: confirmed offline the failure is unrelated. The failure does not look familiar:
|
cshung
approved these changes
Jan 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICorDebugHeapEnum::Nextfails to iterate the heap. It stems from this check. For ephemeral segment/region - we should always report gen 0 to ensure initialization of the first object in the allocating ephemeral segment. Fix the reporting to consistently use gen0.Backport of #96640 to release/8.0-staging
/cc @hoyosjs @cshung
Customer Impact
Customer reported inability to walk the heap using
ICorDebugHeapEnum::Next.Testing
Manual testing of the scenario shows the regression is solved. Debugger tests show no regression. Currently waiting for customer to confirm current builds fix the reported issue for their scenario.
Risk
Low. The only scenario that can regress out of this change is precisely the one that's broken. This is fully contained to the
DAC and has no application runtime impact.