Skip to content

Conversation

@ManickaP
Copy link
Member

@ManickaP ManickaP commented Nov 29, 2023

Fixes #95158

Customer Impact

Test-only change, cleaning up CI noise.

Testing

Locally made sure the test is skipped, also CI.

Risk

Low - only test change and only for mock transport (used only in tests).

cc @carlossanlop @karelz

@ghost ghost added the area-System.Net.Quic label Nov 29, 2023
@ghost ghost assigned ManickaP Nov 29, 2023
@ManickaP ManickaP requested a review from a team November 29, 2023 15:17
@ghost
Copy link

ghost commented Nov 29, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Customer Impact

Only test change, cleaning up CI runs.

Testing

Locally made sure the test is skipped, also CI.

Risk

Low - only test change and only for mock transport (used only in tests).

Fixes #95158

cc @carlossanlop @karelz

Author: ManickaP
Assignees: -
Labels:

area-System.Net.Quic

Milestone: -

@karelz karelz added this to the 6.0.x milestone Nov 29, 2023
@karelz karelz added the Servicing-consider Issue for next servicing release review label Nov 29, 2023
@karelz
Copy link
Member

karelz commented Nov 29, 2023

@artl93 FYI - test-only change in 6.0.x. I believe it should be Tell mode only.

@artl93 artl93 added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 29, 2023
@ManickaP
Copy link
Member Author

ManickaP commented Dec 1, 2023

Approved and test-only change, merging.

@ManickaP ManickaP merged commit 93e8c5c into dotnet:release/6.0-staging Dec 1, 2023
@ManickaP ManickaP deleted the release/6.0-staging branch December 1, 2023 08:56
@ManickaP ManickaP restored the release/6.0-staging branch December 1, 2023 08:56
@github-actions github-actions bot locked and limited conversation to collaborators Jan 1, 2024
@ManickaP ManickaP deleted the release/6.0-staging branch January 4, 2024 05:59
@karelz karelz added the test-bug Problem in test source code (most likely) label Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Net.Quic Servicing-approved Approved for servicing release test-bug Problem in test source code (most likely)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants