Skip to content

[IGNORE][wasi] cleanup use of EmitBundle* task #95384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
radical wants to merge 4 commits into from
Closed

[IGNORE][wasi] cleanup use of EmitBundle* task #95384

radical wants to merge 4 commits into from

Conversation

@radical
Copy link
Member

@radical radical commented Nov 29, 2023

No description provided.

@radical radical added arch-wasm WebAssembly architecture area-Build-mono labels Nov 29, 2023
@ghost
Copy link

ghost commented Nov 29, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono
Milestone: -

@ghost ghost assigned radical Nov 29, 2023
@radical radical added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Nov 29, 2023
@radical
[wasi] EmitBuildBase: Output an item for the bundle file also. This i…
7a65e2b 
…s correct as it represents all the outputs
@radical
[wasi] WasiApp.Native.targets: Simplify target for bundling resources…
a61bb37 
… in single file bundle, and remove special cased way of handling bundlefiles
@radical
[wasi] EmitBundleBase: ReleaseCores once the execution is done, as ms…
c52ea55 
…build does not seem to release them between batched task invocations
@radical
[wasi] Makefile: add build-packages target
2a8434e
@radical radical force-pushed the wasi-emit-bundle-fixes branch from 743f03f to 2a8434e Compare November 29, 2023 21:01
@radical radical closed this Nov 29, 2023
@radical radical deleted the wasi-emit-bundle-fixes branch November 29, 2023 21:02
@radical radical restored the wasi-emit-bundle-fixes branch November 29, 2023 21:02
This was referenced Nov 29, 2023
Closed
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@maraf maraf Awaiting requested review from maraf maraf will be requested when the pull request is marked ready for review maraf is a code owner

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger will be requested when the pull request is marked ready for review akoeplinger is a code owner

@lewing lewing Awaiting requested review from lewing lewing will be requested when the pull request is marked ready for review lewing is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara will be requested when the pull request is marked ready for review pavelsavara is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@radical radical

Labels

arch-wasm WebAssembly architecture area-Build-mono NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@radical