[release/8.0-staging] [mono][System.Reflection.Emit] Fix explicitly setting the return type on a dynamic method#95271
Merged
ivanpovazan merged 1 commit intorelease/8.0-stagingfrom Dec 6, 2023
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-reflection-emit Issue DetailsBackport of #95183 to release/8.0-staging /cc @ivanpovazan Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
lambdageek
approved these changes
Nov 27, 2023
buyaa-n
approved these changes
Nov 27, 2023
Member
|
CI failures are not related. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #95183 to release/8.0-staging
/cc @ivanpovazan
Customer Impact
Customers using
System.Reflection.Emiton mobile and WebAssembly platforms are able to use theMethodBuilder.SetReturnTypefunction to create methods in classes that implement interfaces.This is a regression in .NET 8 due to #78544 which was revealed in ASP.NET tests using SignalR on RHEL as reported in #94490.
Testing
CI and manual testing.
Risk
Low.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.