Skip to content

Conversation

@vargaz
Copy link
Contributor

@vargaz vargaz commented Nov 21, 2023

…it works on wasi.

@ghost ghost assigned vargaz Nov 21, 2023
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 21, 2023
@vargaz vargaz added NO-REVIEW Experimental/testing PR, do NOT review it arch-wasm WebAssembly architecture and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 21, 2023
@ghost
Copy link

ghost commented Nov 21, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

…it works on wasi.

Author: vargaz
Assignees: vargaz
Labels:

NO-REVIEW, arch-wasm

Milestone: -

@vargaz
Copy link
Contributor Author

vargaz commented Nov 21, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vargaz vargaz force-pushed the wasm-emulate-unwind branch from 07cc05c to a818919 Compare November 21, 2023 18:03
@vargaz
Copy link
Contributor Author

vargaz commented Nov 21, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lewing lewing changed the title Add a optional mode on wasm which doesn't depend on c++ unwinding so … Add a optional AOT mode on wasm which doesn't depend on c++ unwinding so … Nov 21, 2023
@lewing lewing mentioned this pull request Nov 21, 2023
34 tasks
@vargaz
Copy link
Contributor Author

vargaz commented Nov 22, 2023

/azp run runtime-wasm

@vargaz vargaz force-pushed the wasm-emulate-unwind branch from a818919 to 69974f6 Compare November 22, 2023 12:56
@vargaz
Copy link
Contributor Author

vargaz commented Nov 22, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vargaz vargaz force-pushed the wasm-emulate-unwind branch from 69974f6 to 282cb71 Compare November 22, 2023 13:49
@vargaz
Copy link
Contributor Author

vargaz commented Nov 22, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vargaz vargaz force-pushed the wasm-emulate-unwind branch from 282cb71 to 023338a Compare November 22, 2023 13:53
@vargaz
Copy link
Contributor Author

vargaz commented Nov 22, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

…it works on wasi.

* Add an constant option to turn on this functionality.
* Add global flag variable to signal whenever manual unwinding is in progress.
* Modify the EH code to check this flag.
* Add new helper functions to either throw/catch a c++ exception or
  set/check the flag.
* Modify AOTed code to check the flag and either return, or branch
  to a landing pad.
@vargaz vargaz force-pushed the wasm-emulate-unwind branch from 023338a to 5c5d0c7 Compare November 22, 2023 14:54
@vargaz
Copy link
Contributor Author

vargaz commented Nov 22, 2023

/azp run runtime-wasm

@vargaz vargaz marked this pull request as ready for review November 22, 2023 14:54
@vargaz vargaz removed the NO-REVIEW Experimental/testing PR, do NOT review it label Nov 22, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lewing lewing merged commit 5382edd into dotnet:main Nov 22, 2023
@vargaz vargaz deleted the wasm-emulate-unwind branch November 22, 2023 18:26
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants