Skip to content

Conversation

@TIHan
Copy link
Contributor

@TIHan TIHan commented Nov 17, 2023

This adds a new environment variable, DOTNET_JitRawHexCode/JitRawHexCodeFile, in Debug/Checked builds that will enable writing the native code in hex to given file or stdout.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 17, 2023
@ghost ghost assigned TIHan Nov 17, 2023
@ghost
Copy link

ghost commented Nov 17, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This adds a new environment variable, DOTNET_JitDisasmHexDumpFile, in Debug/Checked builds that will enable writing the native code in hex to a file for the given DOTNET_JitDisasm.

Author: TIHan
Assignees: TIHan
Labels:

area-CodeGen-coreclr

Milestone: -

@TIHan
Copy link
Contributor Author

TIHan commented Nov 17, 2023

@dotnet/jit-contrib @kunalspathak

Copy link
Contributor

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I would go something without "disasm" (because it does not have mnemonics) and add "raw" in it . Something like JitRawHexCodeFile or similar.

@TIHan TIHan changed the title JIT: Added DOTNET_JitDisasmHexDumpFile JIT: Added DOTNET_RawHexCode/RawHexCodeFile Nov 17, 2023
@TIHan TIHan changed the title JIT: Added DOTNET_RawHexCode/RawHexCodeFile JIT: Added DOTNET_JitRawHexCode/JitRawHexCodeFile Nov 17, 2023
@TIHan
Copy link
Contributor Author

TIHan commented Nov 17, 2023

@dotnet/jit-contrib this is ready again.

Copy link
Contributor

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TIHan TIHan merged commit 9bc37cb into dotnet:main Nov 18, 2023
@TIHan TIHan deleted the hex-dump branch November 18, 2023 04:05
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants