Skip to content

Conversation

@buyaa-n
Copy link
Contributor

@buyaa-n buyaa-n commented Nov 3, 2023

Adds implementation for Label BeginExceptionBlock(), BeginCatchBlock(Type? exceptionType), BeginExceptFilterBlock(), BeginFinallyBlock(), BeginFaultBlock() and EndExceptionBlock() for the new ILGenerator implementation.

Contributes to #92975

@ghost
Copy link

ghost commented Nov 3, 2023

Tagging subscribers to this area: @dotnet/area-system-reflection-emit
See info in area-owners.md if you want to be subscribed.

Issue Details

Adds implementation for Label BeginExceptionBlock(), BeginCatchBlock(Type? exceptionType), BeginExceptFilterBlock(), BeginFinallyBlock(), BeginFaultBlock() and EndExceptionBlock() for the new ILGenerator implementation.

Contributes to #92975

Author: buyaa-n
Assignees: -
Labels:

area-System.Reflection.Emit

Milestone: -

Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reference you are using?

@buyaa-n
Copy link
Contributor Author

buyaa-n commented Nov 6, 2023

Is there a specific reference you are using?

Existing RuntimeILGenerator, ECMA-335 spec, area experts, Reflection.Emit and Reflection.MetadataBuilder docs, SharpLab, ILSPy etc which ever I could find

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@buyaa-n buyaa-n merged commit 6ffa548 into dotnet:main Nov 14, 2023
@buyaa-n buyaa-n deleted the exception branch November 14, 2023 16:20
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants