Skip to content

Conversation

@elinor-fung
Copy link
Member

These were building a self-contained app targeting netcoreapp3.0/3.1 and then running the single-file bundler on everything in the self-contained publish output directory. With 3.1 having been out of support for nearly a year, I don't think they add much value. We have other tests that target the extraction behaviour via bundler options.

@ghost ghost added the area-Single-File label Oct 27, 2023
@ghost ghost assigned elinor-fung Oct 27, 2023
@ghost
Copy link

ghost commented Oct 27, 2023

Tagging subscribers to this area: @agocke, @vitek-karas, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

These were building a self-contained app targeting netcoreapp3.0/3.1 and then running the single-file bundler on everything in the self-contained publish output directory. With 3.1 having been out of support for nearly a year, I don't think they add much value. We have other tests that target the extraction behaviour via bundler options.

Author: elinor-fung
Assignees: elinor-fung
Labels:

area-Single-File

Milestone: -

@vitek-karas
Copy link
Member

I'm a bit undecided on this - while 3.1 is out of support, technically SDK still supports building 3.1 apps (even we don't really support running them). If we have an end-to-end test in SDK for this, then I think it's OK to remove it here, but I think it would be good to have a test somewhere.

@elinor-fung
Copy link
Member Author

Sorry, I should have mentioned in the description - SDK does have tests for this:
https://github.com/dotnet/sdk/blob/70c18f453300aa3e47e186cd46f7970807a451a8/src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishASingleFileApp.cs#L739-L759

While the one in this repo does use the live HostModel, it also relies on trying to approximate what the SDK does. I don't think the bundler itself is that risky in terms of churn such that it affects 3.1 behaviour, so I'd rather just rely on the SDK tests.

Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elinor-fung elinor-fung merged commit 97f7738 into dotnet:main Oct 30, 2023
@elinor-fung elinor-fung deleted the removebundleLegacy branch October 30, 2023 19:17
@ghost ghost locked as resolved and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants