Override InformationalVersion for NativeAOT corelib too #93889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already do this for CoreCLR and Mono since dotnet#60572 but we never did this for NativeAOT. This resulted in the assembly having a version suffix in the AssemblyInformationalVersionAttribute when using stabilized package versions which caused the processinfo2 and processinfo3 tests to fail.
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsWe already do this for CoreCLR and Mono since #60572 but we never did this for NativeAOT.
|
hoyosjs
approved these changes
Oct 23, 2023
agocke
approved these changes
Oct 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already do this for CoreCLR and Mono since #60572 but we never did this for NativeAOT.
Without this the assembly has a version suffix in the AssemblyInformationalVersionAttribute when using stabilized package versions which caused the processinfo2 and processinfo3 tests to fail.