Skip to content

JIT: Fix LowerHWIntrinsicCreate LIR ordering issues #93210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jakobbotsch merged 4 commits into from
Oct 9, 2023
Merged

JIT: Fix LowerHWIntrinsicCreate LIR ordering issues #93210

jakobbotsch merged 4 commits into from
Oct 9, 2023

Conversation

@jakobbotsch
Copy link
Member

@jakobbotsch jakobbotsch commented Oct 9, 2023

LowerHWIntrinsicCreate was assuming in many places that operand nodes come in order, which is fundamentally not an assumption that can be made for LIR.

Fix #92766

@jakobbotsch
JIT: Fix LowerHWIntrinsicCreate LIR ordering issues
6e40556 
LowerHWIntrinsicCreate was assuming in many places that operand nodes
come in order, which is fundamentally not an assumption that can be made
for LIR.

Fix dotnet#92766
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 9, 2023
@ghost ghost assigned jakobbotsch Oct 9, 2023
@ghost
Copy link

ghost commented Oct 9, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

LowerHWIntrinsicCreate was assuming in many places that operand nodes come in order, which is fundamentally not an assumption that can be made for LIR.

Fix #92766

Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@jakobbotsch jakobbotsch mentioned this pull request Oct 9, 2023
Open
@jakobbotsch
Copy link
Member Author

jakobbotsch commented Oct 9, 2023

cc @dotnet/jit-contrib PTAL @kunalspathak @BruceForstall

No diffs. Initially I just inserted the new nodes before node, which is what we would usually do, but that had quite a few regressions since that created a lot of long lifetimes for the operands. So I ended up with the LastNode helper.

@jakobbotsch jakobbotsch marked this pull request as ready for review October 9, 2023 18:15
BruceForstall
BruceForstall approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jakobbotsch jakobbotsch merged commit b4ae22c into dotnet:main Oct 9, 2023
@jakobbotsch jakobbotsch deleted the fix-92766 branch October 9, 2023 18:58
@jakobbotsch jakobbotsch mentioned this pull request Oct 10, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kunalspathak kunalspathak Awaiting requested review from kunalspathak

1 more reviewer

@BruceForstall BruceForstall BruceForstall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jakobbotsch jakobbotsch

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JIT: LowerHWIntrinsicCreate can create illegal IR

2 participants

@jakobbotsch @BruceForstall