[mono][hotreload] Generate seq_points if we don't have pdb information from HotReload #93039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdageek
reviewed
Oct 5, 2023
lambdageek
reviewed
Oct 5, 2023
Member
lambdageek
left a comment
There was a problem hiding this comment.
Mostly looks ok, but I don't think we need to add a new public API for this.
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos Issue DetailsSometimes when we apply changes on runtime side we don't receive the PDB information, so we should try to generate the seq points using the same rules used by coreclr. Maybe in the future we can use these rules always and then avoid runtime loading the PDB information???
|
Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
lambdageek
approved these changes
Oct 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when we apply changes on runtime side we don't receive the PDB information, so we should try to generate the seq points using the same rules used by coreclr.
Maybe in the future we can use these rules always and then avoid runtime loading the PDB information???