Skip to content

Support specifying multiple directories through SSL_CERT_DIR. #92920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vcsjones merged 4 commits into from
Oct 11, 2023
Merged

Support specifying multiple directories through SSL_CERT_DIR. #92920

vcsjones merged 4 commits into from
Oct 11, 2023

Conversation

@tmds
Copy link
Member

@tmds tmds commented Oct 3, 2023

Fixes #91110.

@bartonjs @vcsjones ptal.

@ghost ghost added area-System.Security community-contribution Indicates that the PR has been added by a community member labels Oct 3, 2023
@ghost
Copy link

ghost commented Oct 3, 2023

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #91110.

@bartonjs @vcsjones ptal.

Author: tmds
Assignees: -
Labels:

area-System.Security
Milestone: -

This was referenced Oct 3, 2023
Open
Closed
@tmds tmds force-pushed the ssl_cert_dir_multiple branch from a6280dd to d26becd Compare October 3, 2023 13:13
@build-analysis build-analysis bot mentioned this pull request Oct 3, 2023
Open
5 tasks
@tmds @bartonjs @vcsjones
Apply suggestions from code review
9e83fa5 
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
Co-authored-by: Kevin Jones <vcsjones@github.com>
@build-analysis build-analysis bot mentioned this pull request Oct 5, 2023
Open
@tmds
Copy link
Member Author

tmds commented Oct 6, 2023

@vcsjones @bartonjs thanks for the prompt reviews! Is this good to merge?

@vcsjones vcsjones merged commit 9aec1e3 into dotnet:main Oct 11, 2023
@vcsjones vcsjones added this to the 9.0.0 milestone Oct 11, 2023
@tmds
Copy link
Member Author

tmds commented Oct 19, 2023

@bartonjs @vcsjones we are backporting this feature into the RHEL .NET 8 builds (more specific: distros that derive of CentOS Stream). We try to avoid having patches that introduce a difference in behavior with upstream .NET. Can you consider backporting this change to the runtime 8.0 branch for inclusion in a 8.0 patch release?

cc @omajid @MichaelSimons

@vcsjones
Copy link
Member

vcsjones commented Oct 19, 2023 •
edited
Loading

cc @jeffhandley for backport request to .NET 8.

@jeffhandley
Copy link
Member

jeffhandley commented Oct 19, 2023

/backport to release/8.0

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6578657107

@github-actions github-actions bot mentioned this pull request Oct 19, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Nov 18, 2023
@bartonjs bartonjs added cryptographic-docs-impact Issues impacting cryptographic docs. Cleared and reused after documentation is updated each release. tracking This issue is tracking the completion of other related issues. labels Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vcsjones vcsjones vcsjones approved these changes

@bartonjs bartonjs bartonjs approved these changes

Assignees

No one assigned

Labels

area-System.Security community-contribution Indicates that the PR has been added by a community member cryptographic-docs-impact Issues impacting cryptographic docs. Cleared and reused after documentation is updated each release. tracking This issue is tracking the completion of other related issues.

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

SSL_CERT_DIR should support multiple paths

4 participants

@tmds @vcsjones @jeffhandley @bartonjs