Skip to content

Conversation

@EgorBo
Copy link
Member

@EgorBo EgorBo commented Sep 18, 2023

Fixes a last-minute typo.

Closes #92246
Closes #92202

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 18, 2023
@ghost ghost assigned EgorBo Sep 18, 2023
@ghost
Copy link

ghost commented Sep 18, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes a last-minute typo.

Closes #92246

Author: EgorBo
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@EgorBo
Copy link
Member Author

EgorBo commented Sep 19, 2023

/azp run runtime-coreclr outerloop, runtime-coreclr libraries-jitstress

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@EgorBo
Copy link
Member Author

EgorBo commented Sep 19, 2023

@BruceForstall or @jakobbotsch can you please take a look? should unblock outerloop or anyone else @dotnet/jit-contrib

small diff: https://dev.azure.com/dnceng-public/public/_build/results?buildId=410576&view=ms.vss-build-web.run-extensions-tab (where we know emit a small/different 64bit constant for bt test)

@jakobbotsch
Copy link
Member

Why are there 0-sized diffs with no textual JitDisasm diff? Can you check some of those cases?

@EgorBo
Copy link
Member Author

EgorBo commented Sep 19, 2023

Why are there 0-sized diffs with no textual JitDisasm diff? Can you check some of those cases?

The optimization converts series of x == cns1 || x == cns2 || ... into GT_SWITCH which may be converted to a bt test by an unrelated phase, e.g.: https://godbolt.org/z/87G37YPfT

the bug is basically that the bitmap vector (that 64bit constant bt works with) could become different (and be less than 0xD11FAB1E) so diff (depending on value) may be still the same in terms of size.

@jakobbotsch
Copy link
Member

Why are there 0-sized diffs with no textual JitDisasm diff? Can you check some of those cases?

the bug is basically that the bitmap vector (that 64bit constant bt works with) could become different (and be less than 0xD11FAB1E) so diff (depending on value) may be still the same in terms of size.

You mean the constant would be different but would still display as 0xD1FFAB1E in both the base and diff?

@BruceForstall
Copy link
Contributor

Is this a case where we JitDump 0xD1FFAB1E but shouldn't? (i.e., it's not a pointer that we would expect to vary between compilations, so why don't we just output the actual constant? Maybe we can't tell if it's a pointer or not at the point of output?)

@BruceForstall
Copy link
Contributor

Since this fixes widespread pipeline failures, I'm going to merge it.

@BruceForstall BruceForstall merged commit b049f42 into dotnet:main Sep 19, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failure: System.Web.Tests.HttpUtilityTest.JavaScriptStringEncode Test failure Interop\\COM\\Dynamic\\Dynamic\\Dynamic.cmd

3 participants