[release/8.0] Update Get/SetFieldValue to Account for EnC #90623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
approved these changes
Aug 15, 2023
Member
|
Do you also want to address #90446 (comment) in this backport? |
jeffschwMSFT
approved these changes
Aug 15, 2023
Member
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we will take for consideration in RC1
Contributor
With the recent RC guidance change, we need the template filled out and an email to Tactics requesting approval. @mikelle-rogers can you please do that? Note: Please don't click on "Update branch". The CI will restart. I can bypass it and merge the PR for you. |
Member
|
We are putting this into RC2 |
Contributor
|
Failure is known and unrelated: #90593 Since this is now targeting RC2, the current approvals are sufficient to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #90446 to release/8.0-rc1
/cc @mikelle-rogers
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.