Skip to content

Fix wasm perf setup#90093

Merged
radical merged 1 commit intodotnet:mainfrom
cincuranet:fix-wasm-v8
Aug 7, 2023
Merged

Fix wasm perf setup#90093
radical merged 1 commit intodotnet:mainfrom
cincuranet:fix-wasm-v8

Conversation

@cincuranet
Copy link
Contributor

@cincuranet cincuranet commented Aug 7, 2023 •
edited
Loading

  • Fixes path to v8 executable.
  • Fixes bash expansion of ${this.version()}.

@cincuranet
* Fixes path to v8 executable.
11ae167 
* Fixes bash expansion of ${this.version()}.
@cincuranet cincuranet self-assigned this Aug 7, 2023
@ghost
Copy link

ghost commented Aug 7, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Fixes path to v8 executable.
  • Fixes bash expansion of ${this.version()}.
Author: cincuranet
Assignees: cincuranet
Labels:

area-Infrastructure-coreclr
Milestone: -

@radical radical merged commit 38166fb into dotnet:main Aug 7, 2023
@cincuranet cincuranet deleted the fix-wasm-v8 branch August 7, 2023 15:34
@cincuranet cincuranet mentioned this pull request Aug 9, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radical radical radical approved these changes

@sblom sblom Awaiting requested review from sblom

@DrewScoggins DrewScoggins Awaiting requested review from DrewScoggins

@LoopedBard3 LoopedBard3 Awaiting requested review from LoopedBard3

@caaavik-msft caaavik-msft Awaiting requested review from caaavik-msft

Assignees

@cincuranet cincuranet

Labels

area-Infrastructure-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cincuranet @radical