SPMI: Throw distinguished exception for recorded exceptions #89978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch back to this scheme, since only looking for the managed exception code does not handle crossgen2/ilc (they throw exceptions across the JIT-EE interface as normal C++ exceptions). I've verified that the JIT does not look closely at the exception codes thrown in any of the places it does EH, which comes down to `impJitErrorTrap` and `runWithErrorTrap`. So changing the exception code should not result in any behavior differences.
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsSwitch back to this scheme, since only looking for the managed exception code does not handle crossgen2/ilc (they throw exceptions across the JIT-EE interface as normal C++ exceptions). I've verified that the JIT does not look closely at the exception codes thrown in any of the places it does EH, which comes down to
|
Member
Author
|
cc @dotnet/jit-contrib PTAL @BruceForstall. I verified that this fixes a bunch of cases in the crossgen2 collections. |
BruceForstall
approved these changes
Aug 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch back to this scheme, since only looking for the managed exception code does not handle crossgen2/ilc (they throw exceptions across the JIT-EE interface as normal C++ exceptions).
I've verified that the JIT does not look closely at the exception codes thrown in any of the places it does EH, which comes down to
impJitErrorTrapandrunWithErrorTrap. So changing the exception code should not result in any behavior differences.