Don't access AlgorithmGroup until necessary #89819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessing CNG properties is (relatively) slow to a cryptographic operation itself. This avoids eagerly reading the AlgorithmGroup property.
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones Issue DetailsAccessing CNG properties is (relatively) slow to a cryptographic operation itself. This avoids eagerly reading the AlgorithmGroup property. PR is best reviewed ignoring whitespace.
|
bartonjs
approved these changes
Aug 1, 2023
Member
Author
|
In the interest of getting this PR in for .NET 8, I simply moved the logic around so that We may want to consider memoizing more CNG properties, which I opened #89821 to track. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing CNG properties is relatively slow to a cryptographic operation itself. This avoids eagerly reading the AlgorithmGroup property.
This fixes a performance regression introduced in #77809 for key operations that need to read KeySize.
PR is best reviewed ignoring whitespace.