Enable new analyzers CA1862, CA1864 in runtime and fix findings.#88700
Merged
buyaa-n merged 2 commits intodotnet:mainfrom Jul 14, 2023
Merged
Enable new analyzers CA1862, CA1864 in runtime and fix findings.#88700buyaa-n merged 2 commits intodotnet:mainfrom
buyaa-n merged 2 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsEnable new analyzers CA1862, CA1864 in runtime and fix findings.
|
buyaa-n
commented
Jul 11, 2023
Contributor
Author
There was a problem hiding this comment.
We might want to if-def .Net framework build and apply the fix
carlossanlop
approved these changes
Jul 11, 2023
Contributor
carlossanlop
left a comment
There was a problem hiding this comment.
Thanks for enabling it. I am not expecting any hits from CA1862 in the runtime repo.
buyaa-n
commented
Jul 11, 2023
...ies/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/AggregationManager.cs
Outdated
Show resolved
Hide resolved
This was referenced Jul 13, 2023
Contributor
Author
|
All failures are unrelated and known |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable new analyzers CA1862, CA1864 in runtime and fix findings.
Prefer using 'StringComparer'/'StringComparison' to perform case-insensitive string comparisonsPrefer the 'IDictionary.TryAdd(TKey, TValue)' method, thanks to @CollinAlpert