Change Parallel to use Environment.TickCount64#87800
Merged
stephentoub merged 2 commits intodotnet:mainfrom Jun 20, 2023
Merged
Change Parallel to use Environment.TickCount64#87800stephentoub merged 2 commits intodotnet:mainfrom
stephentoub merged 2 commits intodotnet:mainfrom
Conversation
Avoid wraparound issues from using Environment.TickCount.
|
Tagging subscribers to this area: @dotnet/area-system-threading-tasks Issue DetailsAvoid wraparound issues from using Environment.TickCount. Fixes #87543
|
danmoseley
reviewed
Jun 20, 2023
src/libraries/System.Threading.Tasks.Parallel/src/System/Threading/Tasks/TaskReplicator.cs
Outdated
Show resolved
Hide resolved
…ding/Tasks/TaskReplicator.cs Co-authored-by: Dan Moseley <danmose@microsoft.com>
tannergooding
approved these changes
Jun 20, 2023
Member
|
Is this something we should consider a backport of? |
Member
Author
It's been like this for over a decade (since the .NET Native days before .NET Core), with only one report of it to my knowledge. I don't think it meets the bar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid wraparound issues from using Environment.TickCount.
Fixes #87543