fix(66229): Fix invalid processing of empty Dictionary node.#86485
Merged
tarekgh merged 1 commit intodotnet:mainfrom May 20, 2023
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration |
f01d0b8 to
c41c884
Compare
This was referenced May 19, 2023
c41c884 to
bd7d032
Compare
Contributor
Author
|
@tarekgh , could you review my current change again? If I correctly understand logs of currently failed tests, then it's linked with unavailable iOS device. |
Contributor
Author
|
/azp run runtime |
|
Commenter does not have sufficient privileges for PR 86485 in repo dotnet/runtime |
tarekgh
reviewed
May 19, 2023
Member
Contributor
Author
There was a problem hiding this comment.
Member
|
@Maximys the failure is not related to your change, and it is known failure https://github.com/dotnet/runtime/pull/86485/checks?check_run_id=13615931751. I guess you are going to fix the code according to my comment #86485 (comment) which will trigger the CI one more time anyway. @layomia the fix here looks good to me. Let me know if you are ok with it too. |
3 tasks
bd7d032 to
a8944dd
Compare
Member
|
Did some tabs creep in? We do 4 space indent |
Contributor
Author
tarekgh
approved these changes
May 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopened #86394
Fixes of #66229
For rerun failed tests by CI.