[wasm] Set WasmEnableWebcil to true by default#86330
Merged
lambdageek merged 2 commits intodotnet:mainfrom May 18, 2023
Merged
Conversation
0a7ae45 to
9d7cb50
Compare
5 tasks
Member
Author
|
the symbol server debugger tests are failing with a pdb checksum mismatch. which is weird because we're apparently reading the debug directory data correctly. but somehow it is wrong |
When using reflection to call a method on BlobReader, make sure to copy the struct after the call since the internal state is modified Fixes PdbChecksum extraction from Webcil files (This was a problem even before webcil-in-wasm)
3bef952 to
9d563a9
Compare
16 tasks
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsSwitch to webcil by default in WebAssembly. Contributes to #80807 Also fix some debugger test failures.
|
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
Member
Author
|
I'm going to hold off on hitting "merge" until I try some aspnetcore and SDK AOT tests locally to get an idea of how much downstream work there will be |
Member
Author
|
@maraf will work on downstream test fixes for dotnet/sdk and dotnet/aspnetcore. We're going to merge this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to webcil by default in WebAssembly.
Contributes to #80807
Also fix some debugger test failures.