[release/8.0-preview4] Comment out support for mtag extension in libunwind#85431
[release/8.0-preview4] Comment out support for mtag extension in libunwind#85431jkotas merged 2 commits intodotnet:release/8.0-preview4from
Conversation
f6aa2ec to
831d52e
Compare
|
Tagging subscribers to this area: @hoyosjs Issue Detailsnull
|
.arch_extension memtag when building with GCC .|
cc @mthalman |
|
Regarding:
I assume we will do a similar change in the main and then reference that commit? |
We can reference the commit during the forwardport to main branch (makes it easier during the updates). |
|
It looks like the PR needs rebasing |
Works around build breaks with some compiler versions. Fixes dotnet/source-build#3424
|
@VSadov thanks for taking a look. To make Preview 4 we will need to merge today. Hopefully we will have a green ci by then, but we will need to monitor it. |
|
@jeffschwMSFT I think the failures were unrelated to the change, since this is a build fix that is specific to nativeaot+arm64+linux, but the PR got behind the base branch and became unmergeable (according to GitHub). I think once NativeAOT builds on linux/arm64, we will know that the fix works (there should be no other effects), but it would be better to see green where it can be green. I'll be watching. |
|
FWIW, I've verified this fix in the pipeline that originally found this issue: Debian11_Offline_MsftSdk_arm64 (internal link). This build leg was previously failing (internal link) without this change. |
Fixes dotnet/source-build#3424
Customer Impact
Break in source build caused by recent upgrade of libunwind from libunwind upstream. The update brought it inline assembly code that does not compile with older compilers.
Comment out the offending code since it is not needed for our libunwind use case.
Testing
Local build
Risk
Low. The change is effectively reverting recent change.