Skip to content

[JIT] ARM64 Fix - Use SetOper instead of ChangeOper to preserve flags#85076

Merged
TIHan merged 1 commit intodotnet:mainfrom
TIHan:arm-unordered-float-cmp-fix
Apr 20, 2023
Merged

[JIT] ARM64 Fix - Use SetOper instead of ChangeOper to preserve flags#85076
TIHan merged 1 commit intodotnet:mainfrom
TIHan:arm-unordered-float-cmp-fix

Conversation

@TIHan
Copy link
Contributor

@TIHan TIHan commented Apr 19, 2023 •
edited
Loading

Description

Resolves #84966

The changes from #84605 resulted in the failing test.

I narrowed down the IL to this:

	ldc.r4		ZERO
	ldc.r4		NAN
	bge.un PASS
	br FAIL

This is an unordered comparison against a float ZERO and float NAN. In the importer, when we see this, the GTF_RELOP_NAN_UN flag gets set on the relop. However, if we decide to later swap the relop, calling ChangeOper will clear this bit which is what resulted in the test failing.

The fix is to use SetOper as it will not clear this flag.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 19, 2023
@ghost ghost assigned TIHan Apr 19, 2023
@ghost
Copy link

ghost commented Apr 19, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

Resolves #84966

The changes from #84605 resulted in the failing test.

I narrowed down the IL to this:

	ldc.r4		ZERO
	ldc.r4		NAN
	bge.un PASS
	br FAIL

This is an unordered comparison against a float ZERO and float NAN. In the importer, when we see this, the GTF_RELOP_NAN_UN flag gets set on the relop. However, if we decide to later swap the relop, calling SetOper will clear this bit which is what resulted in the test failing.

I added gtSwapRelop to take into account the GTF_RELOP_NAN_UN flag to make sure it remains on the relop.

Author: TIHan
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@TIHan
Copy link
Contributor Author

TIHan commented Apr 19, 2023

/azp run runtime-coreclr jitstress

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 19, 2023

Azure Pipelines successfully started running 1 pipeline(s).

tannergooding
tannergooding reviewed Apr 19, 2023
View reviewed changes
@TIHan
Copy link
Contributor Author

TIHan commented Apr 20, 2023

/azp run runtime-coreclr jitstress

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 20, 2023

Azure Pipelines successfully started running 1 pipeline(s).

SingleAccretion
SingleAccretion reviewed Apr 20, 2023
View reviewed changes
@TIHan TIHan force-pushed the arm-unordered-float-cmp-fix branch from 8b9c63c to 166babb Compare April 20, 2023 16:10
@TIHan TIHan changed the title [JIT] ARM64 Fix - Added 'gtSwapRelop' to take into account the unordered nan flag [JIT] ARM64 Fix - Use SetOper instead of ChangeOper to preserve flags Apr 20, 2023
@TIHan
Copy link
Contributor Author

TIHan commented Apr 20, 2023

/azp run runtime-coreclr jitstress

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 20, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@TIHan
Copy link
Contributor Author

TIHan commented Apr 20, 2023

@dotnet/jit-contrib This is ready. // cc @jakobbotsch

@build-analysis build-analysis bot mentioned this pull request Apr 20, 2023
Closed
@TIHan TIHan merged commit 614d683 into dotnet:main Apr 20, 2023
@TIHan TIHan deleted the arm-unordered-float-cmp-fix branch April 20, 2023 19:02
@ghost ghost locked as resolved and limited conversation to collaborators May 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tannergooding tannergooding tannergooding left review comments

@jakobbotsch jakobbotsch jakobbotsch approved these changes

+1 more reviewer

@SingleAccretion SingleAccretion SingleAccretion left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@TIHan TIHan

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[JitStress] JIT/IL_Conformance/Old/Conformance_Base/bge_un* failures

4 participants

@TIHan @jakobbotsch @tannergooding @SingleAccretion