Simplify impSIMDPopStack and delete a quirk from gtNewLoadValueNode#85070
Simplify impSIMDPopStack and delete a quirk from gtNewLoadValueNode#85070EgorBo merged 2 commits intodotnet:mainfrom
impSIMDPopStack and delete a quirk from gtNewLoadValueNode#85070Conversation
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsTakes advantage of recent IR improvements.
|
tannergooding
left a comment
There was a problem hiding this comment.
Nice improvement! This may conflict with one more of the AVX-512 PRs. Most are just attaching to existing switch cases though, so hopefully not too bad
|
Couple regressions, nothing major but the Matrix4x4 one would be nice to fix as it will show up in perf runs. Did quite a bit of work improving that in .NET 8 and it was almost perfect (minus a couple register to register moves) and now has a bit of spilling again. -- Happy to tweak the managed code if its something we can fix there instead. I haven't looked at switching to BitCast yet and its doing "weird" things with Unsafe.As to get the good codegen atm. |
Fixes some regressions.
impSIMDPopStackimpSIMDPopStack and delete a quirk from gtNewLoadValueNode
|
The couple regressions in tests are due to the new logic using @dotnet/jit-contrib |
tannergooding
left a comment
There was a problem hiding this comment.
Thanks for fixing the Matrix scenario!
Takes advantage of recent IR improvements.
Diffs.