Conversation
|
Tagging subscribers to this area: @dotnet/ncl |
| // Ubuntu has ping under /bin, OSX under /sbin, ArchLinux under /usr/bin, Android under /system/bin. | ||
| private static readonly string[] s_binFolders = { "/bin/", "/sbin/", "/usr/bin/", "/system/bin" }; | ||
| // Ubuntu has ping under /bin, OSX under /sbin, ArchLinux under /usr/bin, Android under /system/bin, NixOS under /run/current-system/sw/bin. | ||
| private static readonly string[] s_binFolders = { "/bin/", "/sbin/", "/usr/bin/", "/system/bin", "/run/current-system/sw/bin/" }; |
There was a problem hiding this comment.
| private static readonly string[] s_binFolders = { "/bin/", "/sbin/", "/usr/bin/", "/system/bin", "/run/current-system/sw/bin/" }; | |
| private static readonly string[] s_binFolders = { "/bin", "/sbin", "/usr/bin", "/system/bin", "/run/current-system/sw/bin" }; |
There was a problem hiding this comment.
Path.Combine handles perfectly the cases with / at the end and without
There was a problem hiding this comment.
trailing slash isn't necessary, matching /system/bin, goes easy on eyes
|
We don't have NixOS in our testing matrix. Did you test it manually? Or do we have a volunteer to do that? |
Yes I did test it, thanks to this awesome github project https://github.com/nix-community/NixOS-WSL and thanks to the fact that the NixOS package manager contains already .NET 8.0 SDK preview 3 https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/compilers/dotnet/versions/8.0.nix Here is the used code |
|
Awesome, thank you and thanks for pointing out the NixOS on WSL project! |


Fixes #83649