Acclerate Vector512 multiply and divide.#84941
Merged
tannergooding merged 7 commits intodotnet:mainfrom Apr 20, 2023
Merged
Conversation
Contributor
|
cc @dotnet/jit-contrib @dotnet/avx512-contrib |
jnyrup
reviewed
Apr 18, 2023
f97e714 to
33a2d46
Compare
Contributor
Author
|
@tannergooding is anything more needed for this ? |
tannergooding
approved these changes
Apr 20, 2023
| { | ||
| assert((simdSize == 16) || (simdSize == 32)); | ||
| assert((simdSize == 16) || (simdSize == 32) || (simdSize == 64)); | ||
| assert(compIsaSupportedDebugOnly(InstructionSet_AVX512DQ_VL)); |
Contributor
There was a problem hiding this comment.
Just so that I understand, does compIsaSupportedDebugOnly(InstructionSet_AVX512DQ_VL) implicitely mean that compIsaSupportedDebugOnly(InstructionSet_AVX512DQ) is also true?
Member
There was a problem hiding this comment.
Yes.
We model the hierarchy via inheritance and nested classes. So Avx512F implies all the ISAs it inherits from.
Avx512F.VL implies Avx512F and all the ISAs it inherits from. Likewise for Avx512F.X64, etc.
Member
|
Resolved the conflict from the just merged ConvertToInt32/Single PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR accelerates
Vector512multiply and divide ops.