Fix double writes for M.Extensions xml docs#84839
Conversation
We don't need the binplace item anymore as the intellisense.targets file already takes care of copying / setting docs xml files. Also stop generating an xml file for shim assemblies under src/libraries/shims as such don't contain any source code. Fixes #84762
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsWe don't need the binplace item anymore as the intellisense.targets file already takes care of copying / setting docs xml files. Fixes #84762 With these changes, the libs subset doesn't have any double writes anymore.
|
| <GetBinPlaceItemsDependsOn Condition="$(MSBuildProjectName.StartsWith('Microsoft.Extensions.'))">$(GetBinPlaceItemsDependsOn);AddDocumentationFileAsBinPlaceItemForExtensionsProjects</GetBinPlaceItemsDependsOn> | ||
| </PropertyGroup> | ||
|
|
||
| <Target Name="AddDocumentationFileAsBinPlaceItemForExtensionsProjects" |
There was a problem hiding this comment.
@ViktorHofer I saw you suggested in the issue to potentially move this to intellisense.targets. Do we still want to do that?
There was a problem hiding this comment.
You can't move something that no longer exists. At least not in the reality that we currently live in.
We don't need the binplace item anymore as the intellisense.targets file already takes care of copying / setting docs xml files.
Also stop generating an xml file for shim assemblies under src/libraries/shims as such don't contain any source code.
Fixes #84762
With these changes, the libs subset doesn't have any double writes anymore.
I also verified that produced package still contain their corresponding xml files:
and same for the artifacts\bin\runtime\net8.0-...\ folder.