Opt-out of default target framework filtering in source-build infra#84811
Opt-out of default target framework filtering in source-build infra#84811NikolaMilosavljevic merged 2 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue Details
We plan to switch the filtering logic to be on by default, and require repos to explicitly opt-out, see dotnet/source-build#3362 'runtime' is already filtering target frameworks using a custom model, and this work will not have an impact: #83899
|
eng/SourceBuild.props
Outdated
|
|
||
| <PropertyGroup> | ||
| <GitHubRepositoryName>runtime</GitHubRepositoryName> | ||
| <NoTargetFrameworkFiltering>true</NoTargetFrameworkFiltering> |
There was a problem hiding this comment.
Please move this here:
Line 293 in 2d9cb2d
Otherwise target framework filtering could happen outside of the "-sb" build when passing /p:DotNetBuildFromSource=true in.
There was a problem hiding this comment.
I thought that ArcadeBuildFromSource was basically the default at this point and that source build was not generally functional without it. That switch would bring in this file. @dotnet/source-build-internal?
There was a problem hiding this comment.
Linux partners actively use the /p:DotNetBuildFromSource switch in their CI, cc @tmds
There was a problem hiding this comment.
Those are usually used as a combo though, I think? Otherwise SourceBuild.props wouldn't be the place to put any source build specific properties.
There was a problem hiding this comment.
Nope, they use the source build switch without depending on Arcade powered source build. See #81480 for more details
runtimedoesn't use target framework filtering in source-build infra.We plan to switch the filtering logic to be on by default, and require repos to explicitly opt-out, see dotnet/source-build#3362
'runtime' is already filtering target frameworks using a custom model, and this work will not have an impact: #83899