Skip to content

Don't reorder blocks too early in helper call expansion #84765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
EgorBo merged 1 commit into from
Apr 13, 2023
Merged

Don't reorder blocks too early in helper call expansion #84765

EgorBo merged 1 commit into from
Apr 13, 2023

Conversation

@EgorBo
Copy link
Member

@EgorBo EgorBo commented Apr 13, 2023

Fixes #84758

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 13, 2023
@ghost ghost assigned EgorBo Apr 13, 2023
@ghost
Copy link

ghost commented Apr 13, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #84758

Author: EgorBo
Assignees: EgorBo
Labels:

area-CodeGen-coreclr
Milestone: -

@EgorBo EgorBo requested a review from kunalspathak April 13, 2023 11:27
@EgorBo
Copy link
Member Author

EgorBo commented Apr 13, 2023 •
edited
Loading

Diffs with TP wins as expected

"Regressions" presumably from places where we previously skipped TLS blocks due to block shuffling (e.g. method had 2 helper calls to expand but during the expansion of the first one we re-shuffled all blocks and the 2nd one was not visitted)

Also, static init expansion previously didn't run block re-ordering.

kunalspathak
kunalspathak approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EgorBo EgorBo merged commit 51c0342 into dotnet:main Apr 13, 2023
@EgorBo EgorBo deleted the fix-broken-runtime-expansion branch April 13, 2023 16:22
@EgorBo
Copy link
Member Author

EgorBo commented Apr 13, 2023

Failure is #84780

@build-analysis build-analysis bot mentioned this pull request Apr 13, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@kunalspathak kunalspathak kunalspathak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@EgorBo EgorBo

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JIT: Assertion failed '!call->IsExpRuntimeLookup()' during 'Lowering nodeinfo'

2 participants

@EgorBo @kunalspathak