Improve DateTime.ParseExact perf for invariant culture#82877
Merged
stephentoub merged 3 commits intodotnet:mainfrom Mar 3, 2023
Merged
Improve DateTime.ParseExact perf for invariant culture#82877stephentoub merged 3 commits intodotnet:mainfrom
stephentoub merged 3 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-globalization Issue DetailsSpeed up the handling of ddd, dddd, MMM, and MMMM parts of a date time format string when using the invariant culture, which is very commonly used in parsing. Today, when one of these is encountered, the relevant array of comparison strings is retrieved from the DateTimeFormatInfo, and each is compared as a prefix against the current position in the input, using a linguistic ignore-case comparison. But for the invariant culture, we don't need to consult any arrays, and can do the comparison much more quickly. These parts dominate the processing of a format like that for RFC1123.
const string Format = "ddd, dd MMM yyyy HH':'mm':'ss 'GMT'";
private string _s = new DateTime(1955, 11, 5, 6, 0, 0, DateTimeKind.Utc).ToString(Format, CultureInfo.InvariantCulture);
[Benchmark]
public void ParseExact() => DateTimeOffset.ParseExact(_s, Format, CultureInfo.InvariantCulture, DateTimeStyles.AllowInnerWhite | DateTimeStyles.AssumeUniversal);
|
Speed up the handling of ddd, dddd, MMM, and MMMM parts of a date time format string when using the invariant culture, which is very commonly used in parsing. Today, when one of these is encountered, the relevant array of comparison strings is retrieved from the DateTimeFormatInfo, and each is compared as a prefix against the current position in the input, using a linguistic ignore-case comparison. But for the invariant culture, we don't need to consult any arrays, and can do the comparison much more quickly. These parts dominate the processing of a format like that for RFC1123.
This was referenced Mar 2, 2023
tarekgh
reviewed
Mar 2, 2023
src/libraries/System.Private.CoreLib/src/System/Globalization/DateTimeParse.cs
Outdated
Show resolved
Hide resolved
tarekgh
reviewed
Mar 2, 2023
src/libraries/System.Private.CoreLib/src/System/Globalization/DateTimeParse.cs
Outdated
Show resolved
Hide resolved
tarekgh
approved these changes
Mar 2, 2023
danmoseley
reviewed
Mar 2, 2023
| } | ||
| else | ||
| { | ||
| // Scan the month names (note that some calendars has 13 months) and find |
Member
There was a problem hiding this comment.
Suggested change
| // Scan the month names (note that some calendars has 13 months) and find | |
| // Scan the month names (note that some calendars have 13 months) and find |
Member
Author
There was a problem hiding this comment.
Thanks. These are both pre-existing. If I have to restart CI for some reason, I'll take the comment fixes.
| { | ||
| // Scan the month names (note that some calendars has 13 months) and find | ||
| // the matching month name which has the max string length. | ||
| // We need to do this because some cultures (e.g. "cs-CZ") which have |
Member
There was a problem hiding this comment.
Suggested change
| // We need to do this because some cultures (e.g. "cs-CZ") which have | |
| // We need to do this because some cultures (e.g. "cs-CZ") have |
Member
Author
|
Failures are known |
This was referenced Mar 3, 2023
Alpine System.Net.Security.Tests failing because of "Cannot load library libgssapi_krb5.so.2"
#82945
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speed up the handling of ddd, dddd, MMM, and MMMM parts of a date time format string when using the invariant culture, which is very commonly used in parsing. Today, when one of these is encountered, the relevant array of comparison strings is retrieved from the DateTimeFormatInfo, and each is compared as a prefix against the current position in the input, using a linguistic ignore-case comparison. But for the invariant culture, we don't need to consult any arrays, and can do the comparison much more quickly. These parts dominate the processing of a format like that for RFC1123.