Permit trailing data when parsing an X.509 certificate by DER content #82688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsThe managed X.509 decoder did not permit trailing data after the DER contents of the certificate. In #82682 it was reported that the Windows and Unix PALs permit this, so we should update the managed PAL to do the same. n.b. I generally liked the managed PAL's behavior here. We can't make Windows and Unix more strict without possibly breaking someone, but we can make the managed implementation more relaxed. Fixes #82682
|
Member
Author
|
/azp run runtime-ioslike runtime-android |
|
No pipelines are associated with this pull request. |
Member
Author
|
/azp help |
Supported commands
See additional documentation. |
Member
Author
|
/azp run runtime-ioslike, runtime-android |
|
Azure Pipelines successfully started running 2 pipeline(s). |
adamsitnik
approved these changes
Feb 27, 2023
Member
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, thank you @vcsjones !
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The managed X.509 decoder did not permit trailing data after the DER contents of the certificate. In #82682 it was reported that the Windows and Unix implementations permit this, so we should update the managed PAL to do the same.
n.b. I generally liked the managed PAL's behavior here. We can't make Windows and Unix more strict without possibly breaking someone, but we can make the managed implementation more relaxed.
Fixes #82682