[wasm] Better support for automated tests in jiterpreter; more opcodes#82281
Merged
kg merged 4 commits intodotnet:mainfrom Feb 17, 2023
Merged
[wasm] Better support for automated tests in jiterpreter; more opcodes#82281kg merged 4 commits intodotnet:mainfrom
kg merged 4 commits intodotnet:mainfrom
Conversation
Member
kg
commented
Feb 17, 2023
- Rearrange the jiterpreter's compile and enter logic so that we enter a trace immediately after compiling it. If you set the minimum hit count to 1 and disable tiering, this appears to run most automated tests in the jiterpreter, which is useful for verifying opcode implementations and flushing out bugs.
- Move the 'do we need to safepoint after this trace?' logic from the end of enter_jiterpreter into the traces themselves now that traces can perform safepoints. Should improve performance for short traces.
- Implemented a few more opcodes that looked worthwhile based on statistics.
…mmediately after compiling traces This allows running tests under jiterp with hitcount=1 and tiering off
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
vargaz
approved these changes
Feb 17, 2023
This was referenced Feb 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.