[mono][interp] Initialize il_offset for allocated basic blocks#82242
Merged
BrzVlad merged 1 commit intodotnet:mainfrom Feb 16, 2023
Merged
[mono][interp] Initialize il_offset for allocated basic blocks#82242BrzVlad merged 1 commit intodotnet:mainfrom
BrzVlad merged 1 commit intodotnet:mainfrom
Conversation
Multiple areas of the interpreter expect all basic blocks to have an associated il_offset. During bblock reorder optimization, we were allocating a new bblock without initializing it with the offset of the preceding bblock.
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos Issue DetailsMultiple areas of the interpreter expect all basic blocks to have an associated il_offset. During bblock reorder optimization, we were allocating a new bblock without initializing it with the offset of the preceding bblock. Fixes local crash in
|
kotlarmilos
approved these changes
Feb 16, 2023
vargaz
approved these changes
Feb 16, 2023
This was referenced Feb 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple areas of the interpreter expect all basic blocks to have an associated il_offset. During bblock reorder optimization, we were allocating a new bblock without initializing it with the offset of the preceding bblock.
Fixes local crash in
System.Text.Json.Testswhen having tiering disabled.