Skip to content

Share test cases for NativeAOT #82216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tlakollo merged 6 commits into from
Feb 22, 2023
Merged

Share test cases for NativeAOT #82216

tlakollo merged 6 commits into from
Feb 22, 2023

Conversation

@tlakollo
Copy link
Contributor

@tlakollo tlakollo commented Feb 16, 2023

Remove Mono.Linker.Tests.Cases and Mono.Linker.Tests.Cases.Expectations projects from NativeAOT and reuse the ones from illink
Disable tests that have not been triaged in NativeAOT
Add the capability to IgnoreTests only for certain configurations
Sync tests between illink and NativeAOT and apply fixes when necessary to make them work

tlakollo and others added 4 commits February 15, 2023 11:57
@tlakollo
Remove Mono.Linker.Tests.Cases and Mono.Linker.Tests.Cases.Expectatio…
9989261 
…ns from NativeAOT and reuse the ones in illink

Update some of the NativeAOT tests
Merge branch 'main' of https://github.com/dotnet/runtime into ShareTe…
82e4663 
…stCases
Disable tests that have not been triaged in nativeAOT
8ca1a83 
Add the capability to IgnoreTests only for certain configurations
Sync tests between illink and NativeAOT and apply fixes when necessary to make them work
lint
621569b
@tlakollo tlakollo added area-NativeAOT-coreclr area-Tools-ILLink .NET linker development as well as trimming analyzers labels Feb 16, 2023
@tlakollo tlakollo added this to the 8.0.0 milestone Feb 16, 2023
@tlakollo tlakollo self-assigned this Feb 16, 2023
@ghost
Copy link

ghost commented Feb 16, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Remove Mono.Linker.Tests.Cases and Mono.Linker.Tests.Cases.Expectations projects from NativeAOT and reuse the ones from illink
Disable tests that have not been triaged in NativeAOT
Add the capability to IgnoreTests only for certain configurations
Sync tests between illink and NativeAOT and apply fixes when necessary to make them work

Author: tlakollo
Assignees: tlakollo
Labels:

area-NativeAOT-coreclr, area-Tools-ILLink
Milestone: 8.0.0

@ghost
Copy link

ghost commented Feb 16, 2023

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

Remove Mono.Linker.Tests.Cases and Mono.Linker.Tests.Cases.Expectations projects from NativeAOT and reuse the ones from illink
Disable tests that have not been triaged in NativeAOT
Add the capability to IgnoreTests only for certain configurations
Sync tests between illink and NativeAOT and apply fixes when necessary to make them work

Author: tlakollo
Assignees: tlakollo
Labels:

area-NativeAOT-coreclr, area-Tools-ILLink
Milestone: 8.0.0

agocke
agocke approved these changes Feb 18, 2023
View reviewed changes
Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from comment

@tlakollo tlakollo mentioned this pull request Feb 21, 2023
Open
11 tasks
Tlakollo added 2 commits February 21, 2023 13:03
Modify meesage to refer to NativeAOT issue
55ade57 
Fix test that was missing some annotations
Disable test case to see if it helps with Linux failure, NativeAOT do…
8074857 
…esnt produce any IL2110, IL2111, IL2112, IL2113
@build-analysis build-analysis bot mentioned this pull request Feb 22, 2023
Closed
@tlakollo tlakollo merged commit 4916b5a into dotnet:main Feb 22, 2023
@tlakollo tlakollo deleted the ShareTestCases branch February 22, 2023 18:39
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@agocke agocke agocke approved these changes

@sbomer sbomer Awaiting requested review from sbomer

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

@vitek-karas vitek-karas Awaiting requested review from vitek-karas

Assignees

@tlakollo tlakollo

Labels

area-NativeAOT-coreclr area-Tools-ILLink .NET linker development as well as trimming analyzers

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tlakollo @agocke