XmlWriter respects NewLineOnAttributes when writing xmlns#81822
Merged
krwq merged 2 commits intodotnet:mainfrom Feb 9, 2023
Merged
XmlWriter respects NewLineOnAttributes when writing xmlns#81822krwq merged 2 commits intodotnet:mainfrom
krwq merged 2 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-xml |
krwq
reviewed
Feb 8, 2023
| await WriteIndentAsync().ConfigureAwait(false); | ||
| } | ||
|
|
||
| await base.WriteStartNamespaceDeclarationAsync(prefix).ConfigureAwait(false); |
Member
There was a problem hiding this comment.
just curious, why not move this logic to base?
Contributor
Author
There was a problem hiding this comment.
Well, I gues you know more about the design decisions of this stuff, but all the indentation is only done in these XxxRawTextWriterIndent classes. I assume to save some bytes when no indentation is needed.
Member
There was a problem hiding this comment.
Design was made long time before I joined the team 😄
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
|
/azp run runtime-libraries-coreclr outerloop-windows |
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
|
Thanks @devsko, overall looks good, just one question and outerloop tests need to run since XML has plenty of them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #80306
Fixes #74840
I updated the tt files but did not use them because they are too far out of sync (tried to fix that also but gave up)