Skip to content

Support targeting iOS platforms with ILCompiler#81476

Merged
ivanpovazan merged 6 commits intodotnet:mainfrom
ivanpovazan:ilc-ios
Feb 3, 2023
Merged

Support targeting iOS platforms with ILCompiler#81476
ivanpovazan merged 6 commits intodotnet:mainfrom
ivanpovazan:ilc-ios

Conversation

@ivanpovazan
Copy link
Member

@ivanpovazan ivanpovazan commented Feb 1, 2023 •
edited
Loading

This PR enables ILCompiler to target iOS and iOSSimulator platforms.

It has been tested against a private branch which includes changes that enable building NativeAOT for iOS platforms.

/cc: @dotnet/ilc-contrib

@ivanpovazan ivanpovazan added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 1, 2023
@ghost ghost assigned ivanpovazan Feb 1, 2023
@ghost
Copy link

ghost commented Feb 1, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

This is a work-in-progress PR of enabling ILCompiler to target iOS and iOSSimulator platforms.

It is being tested against a private branch which includes changes that enable building NativeAOT for iOS platforms.

/cc: https://github.com/orgs/dotnet/teams/ilc-contrib

Author: ivanpovazan
Assignees: -
Labels:

NO-MERGE, area-NativeAOT-coreclr
Milestone: -

akoeplinger
akoeplinger reviewed Feb 1, 2023
View reviewed changes
ivanpovazan
ivanpovazan commented Feb 1, 2023
View reviewed changes
@filipnavara
Copy link
Member

filipnavara commented Feb 1, 2023

Btw, this line will likely need to be updated once this lands.

marek-safar
marek-safar reviewed Feb 2, 2023
View reviewed changes
@SamMonoRT SamMonoRT requested a review from rolfbjarne February 2, 2023 14:37
jkotas
jkotas approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is there a reason why you have marked it as NO-MERGE?

@ivanpovazan
Copy link
Member Author

ivanpovazan commented Feb 2, 2023

LGTM. Is there a reason why you have marked it as NO-MERGE?

@jkotas, I thought of waiting for the dependent issue (from the PR's description) to be closed first.

@jkotas
Copy link
Member

jkotas commented Feb 2, 2023

@jkotas, I thought of waiting for the dependent issue (from the PR's description) to be closed first.

I do not think we need to wait for the other issue to be closed. This PR looks good to me as-is.

@filipnavara
Copy link
Member

filipnavara commented Feb 2, 2023

I do not think we need to wait for the other issue to be closed

+1. This unblocks some work in other repositories.

@ivanpovazan ivanpovazan removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 2, 2023
@ivanpovazan ivanpovazan marked this pull request as ready for review February 2, 2023 16:10
@ivanpovazan ivanpovazan changed the title WIP: Support targeting iOS platforms with ILCompiler Support targeting iOS platforms with ILCompiler Feb 2, 2023
@MichalStrehovsky MichalStrehovsky mentioned this pull request Feb 2, 2023
Merged
@ivanpovazan ivanpovazan merged commit 47071da into dotnet:main Feb 3, 2023
@ivanpovazan ivanpovazan deleted the ilc-ios branch February 3, 2023 15:13
@ghost ghost locked as resolved and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marek-safar marek-safar marek-safar left review comments

@jkotas jkotas jkotas approved these changes

@MichalStrehovsky MichalStrehovsky MichalStrehovsky left review comments

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@akoeplinger akoeplinger akoeplinger approved these changes

+1 more reviewer

@filipnavara filipnavara filipnavara left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ivanpovazan ivanpovazan

Labels

area-NativeAOT-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support targeting iOS platforms with ILCompiler

7 participants

@ivanpovazan @filipnavara @jkotas @rolfbjarne @marek-safar @akoeplinger @MichalStrehovsky