Add tests for exercising certificates with platform provider keys #80558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsWith #77801, #77809, and #80457, we can now correctly issue and use an Let's add a test that does and end-to-end test and then I think we can close it. Closes #75971
|
adamsitnik
approved these changes
Jan 13, 2023
Member
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, thank you @vcsjones !
src/libraries/System.Security.Cryptography/tests/X509Certificates/CertTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography/tests/X509Certificates/CertTests.cs
Outdated
Show resolved
Hide resolved
Member
|
/azp list |
Member
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
68c1e69 to
354cbd9
Compare
Member
Author
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
adamsitnik
approved these changes
Jan 16, 2023
Member
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, thank you for the additional refactoring!
Member
|
The failures are unrelated, merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #77801, #77809, and #80457, we can now correctly issue and use an
X509Certificate2with a key backed by a Platform Provider TPM key, both for RSA and ECDSA.Let's add a test that does and end-to-end test and then I think we can close it.
Closes #75971