Change github illink links #80407
Change github illink links #80407
Conversation
Delete scripts that clone illink into runtime since illink now lives in runtime Create a forward link for error 1012 in illink, that leads users to open an issue in runtime
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas Issue DetailsChange github illink links to point from dotnet/linker to dotnet/runtime This PR does not cover renaming all the uses of the word linker to illink.
|
| </data> | ||
| <data name="LinkerUnexpectedErrorMessage" xml:space="preserve"> | ||
| <value>IL Trimmer has encountered an unexpected error. Please report the issue at https://github.com/dotnet/linker/issues</value> | ||
| <value>IL Trimmer has encountered an unexpected error. Please report the issue at https://aka.ms/AAj69i2</value> |
There was a problem hiding this comment.
Side note (not necessarily for this PR): It's weird that we have a shared error message which is "for the linker". I definitely hope that NativeAOT doesn't use this. Ideally this should be moved to non-shared code (even if we have to duplicate it, since we probably want different message to be shown from NativeAOT)
There was a problem hiding this comment.
NativeAOT will not make use of the IL1012 since is produced by illink Driver file (which is not shared with NativeAOT).
At this moment we don't even have a DiagnosticId range for NativeAOT-specific errors (and I'm not sure that we want one), we could always reuse the warning range IL3050+ to display something similar if needed.
I still believe that DiagnosticIds should be shared given that most of the warnings can be reused by NativeAOT, and if not used they can just be ignored, illink basically ignores NativeAOT and single file warning Ids.
There was a problem hiding this comment.
I agree that we should share diagnostic IDs (to a point), my point was about the message string in this case - that ideally we would have a way to specify different message for illink/ilc because they might need to mention the tool by name. But it's not a big problem rigth now.
Change github illink links to point from dotnet/linker to dotnet/runtime
Delete scripts that clone illink into runtime since illink now lives in runtime
Create a forward link for error 1012 in illink, which leads users to open an issue in runtime
This PR does not cover renaming all the uses of the word linker to illink.