Skip to content

[wasm] mount VFS archive instead of copying it to MEMFS #79506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pavelsavara wants to merge 3 commits into from
Closed

[wasm] mount VFS archive instead of copying it to MEMFS #79506

pavelsavara wants to merge 3 commits into from

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Dec 11, 2022

  • reduces load of dotnet.timezones.blat from 60ms to 3ms
  • remove free on method name which should not be done

@maraf this doesn't really solve it for memory snapshot. But I think we could implement similar read only VFS overlay in libs/native level and solve this also for WASI. Storing the files and hierarchy directly in the main memory.

@pavelsavara pavelsavara self-assigned this Dec 11, 2022
@ghost
Copy link

ghost commented Dec 11, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • reduces load of dotnet.timezones.blat from 60ms to 3ms
  • remove free on method name which should not be done

@maraf this doesn't really solve it for memory snapshot. But I think we could implement similar read only VFS overlay in libs/native level and solve this also for WASI. Storing the files and hierarchy directly in the main memory.

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: -

@pavelsavara
Copy link
Member Author

pavelsavara commented Dec 11, 2022

System.Tests.TimeZoneInfoTests.IsDaylightSavingTime
Could not find a part of the path '/usr/share/zoneinfo/Europe/London'.

ilonatommy
ilonatommy reviewed Dec 12, 2022
View reviewed changes
ilonatommy
ilonatommy reviewed Dec 12, 2022
View reviewed changes
@runfoapp runfoapp bot mentioned this pull request Dec 12, 2022
Open
@lewing
Copy link
Member

lewing commented Dec 21, 2022 •
edited
Loading

This is really interesting in that there is clearly some value in a cheap read only filesystem for static data and maybe we could combine this sort of sync io with @lambdageek's green thread prototype without exposing any of the complexity to the runtime

@ghost ghost closed this Jan 20, 2023
@ghost
Copy link

ghost commented Jan 20, 2023

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@pavelsavara pavelsavara mentioned this pull request Feb 15, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Feb 19, 2023
@pavelsavara pavelsavara deleted the wasm_timezones_vfs branch September 2, 2024 15:29
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ilonatommy ilonatommy ilonatommy left review comments

@kg kg Awaiting requested review from kg

@maraf maraf Awaiting requested review from maraf

@lewing lewing Awaiting requested review from lewing lewing will be requested when the pull request is marked ready for review lewing is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@pavelsavara pavelsavara

Labels

arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pavelsavara @lewing @ilonatommy