Improve serialization support for nested dictionaries#784
Merged
layomia merged 3 commits intodotnet:masterfrom Dec 20, 2019
Merged
Improve serialization support for nested dictionaries#784layomia merged 3 commits intodotnet:masterfrom
layomia merged 3 commits intodotnet:masterfrom
Conversation
Member
|
Can this please be reviewed as well as dotnet/corefx#42772 (servicing)? @steveharter @ahsonkhan |
steveharter
approved these changes
Dec 18, 2019
| newBaseTypes.AddRange(nonGenericDictTypes); | ||
| } | ||
|
|
||
| baseDictionaryTypes = newBaseTypes; |
Contributor
There was a problem hiding this comment.
I see. By replacing the variable the next loop will create a nested dictionary<string, TValue> where TValue is the current dictionary type.
Member
|
@layomia Please use "Squash & Merge" option to merge your PRs next time. https://github.com/dotnet/runtime/blob/master/docs/issues-pr-management.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5.0 fix for #670.
dotnet/corefx#42772 ports this change to 3.1.