Switch LightupAppActivation tests to component tests targeting additional deps
#78139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsThe Deleted tests and their replacements:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LightupAppActivationtests are testing handling of additional deps. The actual app and lib are not really interesting, so we can switch them to the dependency resolution tests that use a mock coreclr and don't actually run an app. On my machine, this goes from ~20s to run the deleted tests to ~700ms to run the new tests.Deleted tests and their replacements:
Muxer_activation_of_LightupApp_NoLightupLib_Fails,Muxer_activation_of_LightupApp_WithLightupLib_SucceedsAdditionalDeps.DepsFileMuxer_activation_of_LightupApp_WithLightupLib_and_Roll_Backwards_From_Release_To_Release_Succeeds,Muxer_activation_of_LightupApp_WithLightupLib_and_Roll_Backwards_From_Prerelease_To_Release_Succeeds,Muxer_activation_of_LightupApp_WithLightupLib_and_Roll_Backwards_FailsAdditionalDeps.DepsDirectoryAdditional_Deps_Lightup_Folder_With_Bad_JsonFileAdditionalDeps.InvalidJsonSharedFx_With_Higher_Version_Wins_Against_Additional_Deps,SharedFx_With_Lower_Version_Loses_Against_Additional_DepsAdditionalDepsPerAssemblyVersionResolution.AppWithSameAssemblyAsFramework