[NativeAOT] Objective-C: SetMessageSendPendingException and SetMessageSendCallback#77956
Merged
marek-safar merged 10 commits intodotnet:mainfrom Nov 11, 2022
Merged
Conversation
This also has the effect of making the src/tests/Interop/ObjectiveC/AutoReleaseTest/ test pass.
7 tasks
This was referenced Nov 7, 2022
...eclr/nativeaot/System.Private.CoreLib/src/Internal/Runtime/CompilerHelpers/InteropHelpers.cs
Outdated
Show resolved
Hide resolved
marek-safar
reviewed
Nov 7, 2022
...eclr/nativeaot/System.Private.CoreLib/src/Internal/Runtime/CompilerHelpers/InteropHelpers.cs
Outdated
Show resolved
Hide resolved
Member
MichalStrehovsky
left a comment
There was a problem hiding this comment.
The compiler side looks good to me otherwise, thanks!
I'd need to read up more about this APIs to sign off on Corelib so I hope someone more qualified reviews that.
...eclr/nativeaot/System.Private.CoreLib/src/Internal/Runtime/CompilerHelpers/InteropHelpers.cs
Outdated
Show resolved
Hide resolved
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/PInvokeMethodFixupNode.cs
Outdated
Show resolved
Hide resolved
* Deduplicate constants by moving them to RuntimeConstants.cs * Move the macOS specific parts of InteropHelpers to a separate file * Move knowledge of Objective-C out of type system files
marek-safar
reviewed
Nov 10, 2022
...eclr/nativeaot/System.Private.CoreLib/src/Internal/Runtime/CompilerHelpers/InteropHelpers.cs
Show resolved
Hide resolved
jkotas
reviewed
Nov 10, 2022
src/coreclr/nativeaot/System.Private.CoreLib/src/System.Private.CoreLib.csproj
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Nov 11, 2022
...eclr/nativeaot/System.Private.CoreLib/src/Internal/Runtime/CompilerHelpers/InteropHelpers.cs
Outdated
Show resolved
Hide resolved
…ime/CompilerHelpers/InteropHelpers.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements
SetMessageSendPendingExceptionandSetMessageSendCallbacktogether, as the tests use both features together.When using a NativeAOT-compatible remote executor (see dotnet/arcade#11460 ), the tests in src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests.
Also, by settings the
FEATURE_OBJCMARSHALdefine and theFeatureObjCMarshalproperty, thesrc/tests/Interop/ObjectiveC/AutoReleaseTest/test now passes.Related issue: #77472