Delete fgMorphBlockOperand#77688
Merged
BruceForstall merged 4 commits intodotnet:mainfrom Nov 12, 2022
Merged
Conversation
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsNo longer necessary as we don't need to compensate for invalid IR. A minor TP improvement is expected, with no code diffs.
|
26d3602 to
67cb0a9
Compare
67cb0a9 to
0dd1168
Compare
Contributor
Author
|
Interesting OSX x64 ( Edit: machine was Edit: I've run the CI a good number of times on this, and it did not reproduce. Will proceed with the change as-is for now. |
2 tasks
fc64545 to
c87e737
Compare
c87e737 to
0f11dc2
Compare
fgMorphBlockOperand<struct>fgMorphBlockOperand
0f11dc2 to
c0e1eab
Compare
fgMorphBlockOperandfgMorphBlockOperand
Contributor
Author
|
@dotnet/jit-contrib SPMI failures are due to missing Win-ARM64 collections. |
BruceForstall
approved these changes
Nov 12, 2022
Contributor
This was due to an undetermined failure to upload files. A recollect is in progress (takes ~6 hours). There is a usual one scheduled on Sundays. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No longer necessary as we don't need to compensate for invalid IR.
Diffs - a TP improvement, plus one small diff where we don't reduce
OBJ(ADDR(LCL_VAR))created by forward substitution, but it ends up being a bit better anyway.