Skip to content

Fix source-build prebuilts introduced by analyzers#77607

Merged
jkotas merged 4 commits intodotnet:mainfrom
jkotas:analyzers
Oct 29, 2022
Merged

Fix source-build prebuilts introduced by analyzers#77607
jkotas merged 4 commits intodotnet:mainfrom
jkotas:analyzers

Conversation

@jkotas
Copy link
Member

@jkotas jkotas commented Oct 28, 2022

Use the default root settings for analyzers and disable analyzers for specific projects that are not clean instead.

Fixes #77601

@ghost ghost assigned jkotas Oct 28, 2022
Use the default root settings for analyzers and disable analyzers for specific projects that are not clean instead.

Fixes dotnet#77601
Copy link
Contributor

@tlakollo tlakollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was having a hard time trying to understand what was the problem. With this PR now I know, when DotNetBuildFromSource is true, RunAnalyzers will be false for all projects and no analyzers will be included. Thanks

@jkotas jkotas merged commit 6756782 into dotnet:main Oct 29, 2022
@jkotas jkotas deleted the analyzers branch October 29, 2022 04:45
@ghost ghost locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ILCompiler projects are causing source-build prebuilts

2 participants