Use char helpers for ASCII portion of Regex character class matching#77604
Merged
stephentoub merged 1 commit intodotnet:mainfrom Oct 28, 2022
Merged
Use char helpers for ASCII portion of Regex character class matching#77604stephentoub merged 1 commit intodotnet:mainfrom
stephentoub merged 1 commit intodotnet:mainfrom
Conversation
If the entire character class is ASCII, we already use char.IsXx helpers when they're equivalent, e.g. [A-Z] will result in using char.IsAsciiLetterUpper. But if the character class contains any non-ASCII, we always use a lookup table for the ASCII portion of the comparison. This PR allows us to similarly use those IsAsciiXx helpers for the ASCII portion.
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions Issue DetailsIf the entire character class is ASCII, we already use char.IsXx helpers when they're equivalent, e.g. [A-Z] will result in using char.IsAsciiLetterUpper. But if the character class contains any non-ASCII, we always use a lookup table for the ASCII portion of the comparison. This PR allows us to similarly use those IsAsciiXx helpers for the ASCII portion. This primarily about making the generated code cleaner, but it can also save a few instructions.
|
joperezr
approved these changes
Oct 28, 2022
danmoseley
reviewed
Oct 28, 2022
src/libraries/System.Text.RegularExpressions/gen/RegexGenerator.Emitter.cs
Show resolved
Hide resolved
danmoseley
reviewed
Oct 28, 2022
...libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexCompiler.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the entire character class is ASCII, we already use char.IsXx helpers when they're equivalent, e.g. [A-Z] will result in using char.IsAsciiLetterUpper. But if the character class contains any non-ASCII, we always use a lookup table for the ASCII portion of the comparison. This PR allows us to similarly use those IsAsciiXx helpers for the ASCII portion. This primarily about making the generated code cleaner, but it can also save a few instructions.